This repository has been archived by the owner on May 29, 2019. It is now read-only.
Fix bugs in givenUser/WithRole when combined withUserModel helper #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary:
- Added tests to verify combined of withUserModel and givenUser (& givenUserWithRole). These failed previously.
- Changed default User model to "User" instead of "user".
- Removed "constructor" in User.login invocations.
- Role.findOrCreate was incorrectly double-nesting the role-name. {name: {name: "testRole"} }
|
Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test." |
| principalType: test.app.models.roleMapping.USER, | ||
| var userModelName = test.userModel ? test.userModel : '__USERMODEL__'; | ||
| test.app.models.RoleMapping.create( | ||
| {principalId: test[userModelName].id, |
Added a new test to verify givenUserWithRole when using the default User model.
LoicMahieu
added a commit
to LoicMahieu/loopback-testing
that referenced
this pull request
Jan 14, 2016
Add tests for givenUser etc... From strongloop-archive/loopback-testing#69
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
withUserModelandgivenUser(&givenUserWithRole). These failed previously.User.logininvocations.{name: {name: "testRole"} }