fix: set app.booting flag immediately
#286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, `app.booting` was set by Application plugin as part of regular phase invocation, which executes individual plugins in subsequent turns of the event loop. As a result, `app.booting` was initially `undefined` despite the fact that the booting process was already in progress. This patch moves manipulation of `app.booting` flag directly to `Bootstrapper#run` method, to ensure it's set early enough and always properly cleared at the end.
This was referenced Mar 22, 2019
raymondfeng
approved these changes
Mar 22, 2019
7 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change,
app.bootingwas set by Application plugin as part of regular phase invocation, which executes individual plugins in subsequent turns of the event loop. As a result,app.bootingwas initiallyundefineddespite the fact that the booting process was already in progress.This patch moves manipulation of
app.bootingflag directly toBootstrapper#runmethod, to ensure it's set early enough and always properly cleared at the end.Related issues
PoC showing how to mount an LB3 app and include its REST API in OpenAPI spec [DO NOT MERGE] loopbackio/loopback-next#2318 where the bug was discovered too
Checklist
guide