Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update README for 2.x EOL #4188

Merged
merged 1 commit into from
May 2, 2019
Merged

update README for 2.x EOL #4188

merged 1 commit into from
May 2, 2019

Conversation

dhmlau
Copy link
Member

@dhmlau dhmlau commented Apr 29, 2019

Description

Related to #4180

  • Update the LTS schedule
  • Update to state 2.x has already reached EOL.

Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am proposing to move the new sentence to "Module Long Term Support Policy" section.

This is what we have now:

## Module Long Term Support Policy

LoopBack 2.x is now in maintenance LTS.

My proposal:

## Module Long Term Support Policy

**LoopBack 2.x has reached end of life in April 2019. It is no longer supported.**

If you prefer to keep the information about 2.x EOL at the top, then I am fine with that too, but please update the sentence "LoopBack 2.x is now on maintenance LTS".

@bajtos
Copy link
Member

bajtos commented Apr 30, 2019

I think it's even more important to update README in our master branch too, that's the content rendered when people arrive at https://github.com/strongloop/loopback and https://www.npmjs.com/package/loopback

@dhmlau
Copy link
Member Author

dhmlau commented Apr 30, 2019

@bajtos, thanks for your review.

If you prefer to keep the information about 2.x EOL at the top, then I am fine with that too, but please update the sentence "LoopBack 2.x is now on maintenance LTS".

Thanks. I'll update the sentence above the LTS table as well. I put it at the top because the master branch has it at the top too. :)

I think it's even more important to update README in our master branch too

Yes, I'll do it in a separate PR for master.

@dhmlau dhmlau merged commit a3619df into 2.x May 2, 2019
@dhmlau dhmlau deleted the 2.x-eol branch May 2, 2019 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants