Skip to content
This repository has been archived by the owner on Jan 10, 2024. It is now read-only.

Commit

Permalink
Removes duplicate property.
Browse files Browse the repository at this point in the history
  • Loading branch information
simonbrowndotje committed Oct 27, 2023
1 parent 670617e commit a6b55e6
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ public abstract class AbstractPlantUMLExporter extends AbstractDiagramExporter {
public static final String PLANTUML_TITLE_PROPERTY = "plantuml.title";
public static final String PLANTUML_INCLUDES_PROPERTY = "plantuml.includes";
public static final String PLANTUML_ANIMATION_PROPERTY = "plantuml.animation";
public static final String PLANTUML_SEQUENCE_DIAGRAM_PROPERTY = "plantuml.sequenceDiagram";

private static final double MAX_ICON_SIZE = 30.0;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ public class C4PlantUMLExporter extends AbstractPlantUMLExporter {
public static final String C4PLANTUML_STANDARD_LIBRARY_PROPERTY = "c4plantuml.stdlib";
public static final String C4PLANTUML_SPRITE = "c4plantuml.sprite";
public static final String C4PLANTUML_SHADOW = "c4plantuml.shadow";
public static final String C4PLANTUML_SEQUENCE_DIAGRAM_PROPERTY = "plantuml.sequenceDiagram";

/**
* <p>Set this property to <code>true</code> by calling {@link Configuration#addProperty(String, String)} in your
Expand Down Expand Up @@ -674,7 +673,7 @@ protected boolean usePlantUMLStandardLibrary(ModelView view) {
}

protected boolean renderAsSequenceDiagram(ModelView view) {
return view instanceof DynamicView && "true".equalsIgnoreCase(getViewOrViewSetProperty(view, C4PLANTUML_SEQUENCE_DIAGRAM_PROPERTY, "false"));
return view instanceof DynamicView && "true".equalsIgnoreCase(getViewOrViewSetProperty(view, PLANTUML_SEQUENCE_DIAGRAM_PROPERTY, "false"));
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@

public class StructurizrPlantUMLExporter extends AbstractPlantUMLExporter {

public static final String PLANTUML_SEQUENCE_DIAGRAM_PROPERTY = "plantuml.sequenceDiagram";
public static final String PLANTUML_SHADOW = "plantuml.shadow";

private int groupId = 0;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ public void test_BigBankPlcExample() throws Exception {
assertEquals(expected, diagram.getDefinition());

// and the sequence diagram version
workspace.getViews().getConfiguration().addProperty(exporter.C4PLANTUML_SEQUENCE_DIAGRAM_PROPERTY, "true");
workspace.getViews().getConfiguration().addProperty(exporter.PLANTUML_SEQUENCE_DIAGRAM_PROPERTY, "true");
diagrams = exporter.export(workspace);
diagram = diagrams.stream().filter(d -> d.getKey().equals("SignIn")).findFirst().get();
expected = readFile(new File("./src/test/java/com/structurizr/export/plantuml/c4plantuml/36141-SignIn-sequence.puml"));
Expand Down

0 comments on commit a6b55e6

Please sign in to comment.