-
-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace low-level file access and HEIF file parsing #1242
Conversation
Not finished, but progressed far enough that I decided to merge it into 'master'. |
The libvips fuzzers detected a crash in this implementation that didn't occur on v1.18.2. $ build-v1.18.2/examples/heif-dec crash-a88cb4551382b7015408ee76bc731e2e99188db6
File contains 2 images
Could not decode image: 0: Invalid input: Unspecified: Corrupt frame detected
$ build-master/examples/heif-dec crash-a88cb4551382b7015408ee76bc731e2e99188db6
terminate called after throwing an instance of 'std::length_error'
what(): vector::_M_default_append
Aborted (core dumped) Is it too early to report bugs found by fuzzers? I could share the file privately or publicly, whichever you prefer. |
@kleisauke Would be great if you could share the file. Just attaching it here would be fine I think. |
Great! You can find the file here: |
@kleisauke Thanks. The out-of-memory crash should be fixed now. |
This is a major rework of how libheif parses input files and handles reading and writing especially large files.
The goal is to