Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add progress report to tiles loading #546

Closed
wants to merge 3 commits into from

Conversation

mnaydenov
Copy link
Contributor

@mnaydenov mnaydenov commented Sep 6, 2021

Add a no-brainer implementation of the progress report, based on the suggestion in #161
Currently only to the non-threaded implementation.

@mnaydenov
Copy link
Contributor Author

mnaydenov commented Sep 7, 2021

@farindk Please consider changing the return type of on_progress and start_progress to "bool" so that one can implement cancelation support. Considering these functions are not used at the moment, this will hardly be a breaking change. If this is considered unacceptable, adding on_progress2 , or is_canceled as a separate function could be an option.
Progress reporting without the ability to cancel is needlessly handicapped.

@bobfriesenhahn
Copy link

As the developer of GraphicsMagick (http://www.graphicsmagick.org/) I would like to see this implemented once the progress monitor actually does something. I am sure that ImageMagick would use it as well.

@bobfriesenhahn
Copy link

I used https://grep.app/ to check for how the decode options passed to heif_decode_image() are used. I did not find any free software which currently attempts to use the progress monitor feature. I have implemented such code for GraphicsMagick but will disable it.

Since there are no apparent users, it should be reasonable to change the function signature.

farindk added a commit that referenced this pull request Oct 15, 2024
farindk added a commit that referenced this pull request Oct 15, 2024
@farindk
Copy link
Contributor

farindk commented Oct 15, 2024

Thanks @mnaydenov

I've added progress reporting and user cancelation.
Sorry, I didn't use this PR because the code has changed so much in the meantime that it was easier to add this from scratch than trying to merge it.

@farindk farindk closed this Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants