feat(http): make ResponseWriter public #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CermakM
requested review from
TomasKocman,
bafko,
Fazt01 and
xburda4
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #37 +/- ##
=======================================
Coverage 67.04% 67.04%
=======================================
Files 12 12
Lines 704 704
=======================================
Hits 472 472
Misses 221 221
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bafko
previously approved these changes
Aug 20, 2024
TomasKocman
previously approved these changes
Aug 20, 2024
Fazt01
previously approved these changes
Aug 22, 2024
CermakM
dismissed stale reviews from Fazt01, TomasKocman, and bafko
via
765b724
|
@bafko updated 👍 Thanks for the reminder. |
TomasKocman
previously approved these changes
Aug 26, 2024
bafko
previously approved these changes
Aug 26, 2024
Signed-off-by: Marek Cermak <[email protected]>
Signed-off-by: Marek Cermak <[email protected]>
CermakM
force-pushed
the
feat/http-expose-response-writer
branch
from
765b724
to
f1eeffa
Compare
|
Rebased. |
bafko
approved these changes
Sep 30, 2024
Fazt01
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ResponseWriteris an important structure accessed by the middleware and used indirectly by the signature package. If we expose it, it's possible to build custom middleware on top of our existing ones, reusing the data stored in the ResponseWriter.