Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(param): parse embedded struct #38

Merged
merged 4 commits into from
Sep 20, 2024
Merged

Conversation

Fazt01
Copy link
Contributor

@Fazt01 Fazt01 commented Sep 16, 2024

Param package can parse into embedded structs. Inspired by json package, where the package CAN set unexported embedded struct (only if non-pointer or non-nil-pointer), as long as it's fields are exported.

Also removed some useless customization to simplify the package (separate commit)

@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.04%. Comparing base (f9d8e66) to head (e4a1b2e).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
+ Coverage   64.08%   67.04%   +2.95%     
==========================================
  Files          12       12              
  Lines         646      704      +58     
==========================================
+ Hits          414      472      +58     
  Misses        221      221              
  Partials       11       11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

http/param/param.go Outdated Show resolved Hide resolved
http/param/param.go Outdated Show resolved Hide resolved
@Fazt01 Fazt01 merged commit 6059f50 into master Sep 20, 2024
3 checks passed
@Fazt01 Fazt01 deleted the feat/param-embedded-struct branch September 20, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants