feat(956) human readable estimates (#956)

packages/stryker/src/reporters/ProgressAppendOnlyReporter.ts

@@ -1,16 +1,13 @@
 import { MatchedMutant } from 'stryker-api/report';
 import * as os from 'os';
 import ProgressKeeper from './ProgressKeeper';
-import Timer from '../utils/Timer';
 
 export default class ProgressAppendOnlyReporter extends ProgressKeeper {
   private intervalReference: NodeJS.Timer;
-  private timer: Timer;
 
   public onAllMutantsMatchedWithTests(matchedMutants: ReadonlyArray<MatchedMutant>): void {
     super.onAllMutantsMatchedWithTests(matchedMutants);
     if (matchedMutants.length) {
-      this.timer = new Timer();
       this.intervalReference = setInterval(() => this.render(), 10000);
     }
   }
@@ -20,21 +17,12 @@ export default class ProgressAppendOnlyReporter extends ProgressKeeper {
   }
 
   private render() {
-    process.stdout.write(`Mutation testing ${this.percent()} (ETC ${this.etc()}) ` +
+    process.stdout.write(`Mutation testing ${this.getPercentDone()} (ETC ${this.getEtc()}) ` +
       `${this.progress.tested}/${this.progress.total} tested (${this.progress.survived} survived)` +
       os.EOL);
   }
 
-  private percent() {
+  private getPercentDone() {
     return Math.floor(this.progress.tested / this.progress.total * 100) + '%';
   }
-
-  private etc() {
-    const etcSeconds = Math.floor(this.timer.elapsedSeconds() / this.progress.tested * (this.progress.total - this.progress.tested));
-    if (isFinite(etcSeconds)) {
-      return etcSeconds + 's';
-    } else {
-      return 'n/a';
-    }
-  }
 }

packages/stryker/src/reporters/ProgressKeeper.ts

@@ -1,17 +1,19 @@
 import { MatchedMutant, Reporter, MutantResult } from 'stryker-api/report';
 import { MutantStatus } from 'stryker-api/report';
+import Timer from '../utils/Timer';
 
 abstract class ProgressKeeper implements Reporter {
-
+  private timer: Timer;
   protected progress = {
     survived: 0,
     tested: 0,
-    total: 0
+    total: 0,
   };
 
   private mutantIdsWithoutCoverage: string[];
 
   public onAllMutantsMatchedWithTests(matchedMutants: ReadonlyArray<MatchedMutant>): void {
+    this.timer = new Timer();
     this.mutantIdsWithoutCoverage = matchedMutants.filter(m => m.scopedTestIds.length === 0).map(m => m.id);
     this.progress.total = matchedMutants.length - this.mutantIdsWithoutCoverage.length;
   }
@@ -24,5 +26,23 @@ abstract class ProgressKeeper implements Reporter {
       this.progress.survived++;
     }
   }
+
+  protected getEtc() {
+    const timeLeft = Math.floor(this.timer.elapsedSeconds() / this.progress.tested * (this.progress.total - this.progress.tested));
+
+    if (isFinite(timeLeft)) {
+      const hours = Math.floor(timeLeft / 3600);
+      const minutes = Math.floor((timeLeft / 60) - (hours * 60));
+      const seconds = Math.floor(timeLeft - (hours * 3600) - (minutes * 60));
+
+      let output = (hours > 0) ? `${hours}h, ` : '';
+      output += (minutes > 0) ? `${minutes}m, ` : '';
+      output += (seconds > 0) ? `${seconds}s` : 0;
+
+      return output;
+    } else {
+      return 'n/a';
+    }
+  }
 }
 export default ProgressKeeper;

packages/stryker/src/reporters/ProgressReporter.ts

@@ -8,7 +8,7 @@ export default class ProgressBarReporter extends ProgressKeeper {
   public onAllMutantsMatchedWithTests(matchedMutants: ReadonlyArray<MatchedMutant>): void {
     super.onAllMutantsMatchedWithTests(matchedMutants);
     const progressBarContent =
-      `Mutation testing  [:bar] :percent (ETC :etas) :tested/:total tested (:survived survived)`;
+      `Mutation testing  [:bar] :percent (ETC :etc) :tested/:total tested (:survived survived)`;
 
     this.progressBar = new ProgressBar(progressBarContent, {
       complete: '=',
@@ -22,18 +22,21 @@ export default class ProgressBarReporter extends ProgressKeeper {
   public onMutantTested(result: MutantResult): void {
     const ticksBefore = this.progress.tested;
     super.onMutantTested(result);
+
+    const progressBarContent = { ...this.progress, etc: this.getEtc() };
+
     if (ticksBefore < this.progress.tested) {
-      this.tick();
+      this.tick(progressBarContent);
     } else {
-      this.render();
+      this.render(progressBarContent);
     }
   }
 
-  private tick(): void {
-    this.progressBar.tick(this.progress);
+  private tick(tickObj: object): void {
+    this.progressBar.tick(tickObj);
   }
 
-  private render(): void {
-    this.progressBar.render(this.progress);
+  private render(renderObj: object): void {
+    this.progressBar.render(renderObj);
   }
 }

packages/stryker/test/unit/reporters/ProgressAppendOnlyReporterSpec.ts

@@ -5,6 +5,11 @@ import { MutantStatus } from 'stryker-api/report';
 import ProgressAppendOnlyReporter from '../../../src/reporters/ProgressAppendOnlyReporter';
 import { matchedMutant, mutantResult } from '../../helpers/producers';
 
+const SECOND = 1000;
+const TEN_SECONDS = SECOND * 10;
+const HUNDRED_SECONDS = SECOND * 100;
+const TEN_THOUSAND_SECONDS = SECOND * 10000;
+
 describe('ProgressAppendOnlyReporter', () => {
   let sut: ProgressAppendOnlyReporter;
   let sandbox: sinon.SinonSandbox;
@@ -13,7 +18,7 @@ describe('ProgressAppendOnlyReporter', () => {
     sut = new ProgressAppendOnlyReporter();
     sandbox = sinon.createSandbox();
     sandbox.useFakeTimers();
-    sandbox.stub(process.stdout, 'write');
+    sandbox.spy(process.stdout, 'write');
   });
 
   afterEach(() => sandbox.restore());
@@ -28,17 +33,31 @@ describe('ProgressAppendOnlyReporter', () => {
       expect(process.stdout.write).to.not.have.been.called;
     });
 
-    it('should log zero progress after 10s without completed tests', () => {
-      sandbox.clock.tick(10000);
+    it('should log zero progress after ten seconds without completed tests', () => {
+      sandbox.clock.tick(TEN_SECONDS);
       expect(process.stdout.write).to.have.been.calledWith(`Mutation testing 0% (ETC n/a) ` +
       `0/2 tested (0 survived)${os.EOL}`);
     });
 
-    it('should should log 50% with 10s ETC after 10s with 1 completed test', () => {
+    it('should log 50% with 10s ETC after ten seconds with 1 completed test', () => {
       sut.onMutantTested(mutantResult({ status: MutantStatus.Killed }));
       expect(process.stdout.write).to.not.have.been.called;
-      sandbox.clock.tick(10000);
+      sandbox.clock.tick(TEN_SECONDS);
       expect(process.stdout.write).to.have.been.calledWith(`Mutation testing 50% (ETC 10s) 1/2 tested (0 survived)${os.EOL}`);
     });
+
+    it('should log 50% with "1m, 40s" ETC after hundred seconds with 1 completed test', () => {
+      sut.onMutantTested(mutantResult({ status: MutantStatus.Killed }));
+      expect(process.stdout.write).to.not.have.been.called;
+      sandbox.clock.tick(HUNDRED_SECONDS);
+      expect(process.stdout.write).to.have.been.calledWith(`Mutation testing 50% (ETC 1m, 40s) 1/2 tested (0 survived)${os.EOL}`);
+    });
+
+    it('should log 50% with "2h, 46m, 40s" ETC after ten tousand seconds with 1 completed test', () => {
+      sut.onMutantTested(mutantResult({ status: MutantStatus.Killed }));
+      expect(process.stdout.write).to.not.have.been.called;
+      sandbox.clock.tick(TEN_THOUSAND_SECONDS);
+      expect(process.stdout.write).to.have.been.calledWith(`Mutation testing 50% (ETC 2h, 46m, 40s) 1/2 tested (0 survived)${os.EOL}`);
+    });
   });
 });

packages/stryker/test/unit/reporters/ProgressReporterSpec.ts

@@ -6,18 +6,25 @@ import * as progressBarModule from '../../../src/reporters/ProgressBar';
 import { matchedMutant, mutantResult, Mock, mock } from '../../helpers/producers';
 import ProgressBar = require('progress');
 
+const SECOND = 1000;
+const TEN_SECONDS = SECOND * 10;
+const HUNDRED_SECONDS = SECOND * 100;
+const TEN_THOUSAND_SECONDS = SECOND * 10000;
+
 describe('ProgressReporter', () => {
 
   let sut: ProgressReporter;
   let sandbox: sinon.SinonSandbox;
   let matchedMutants: MatchedMutant[];
   let progressBar: Mock<ProgressBar>;
-  const progressBarContent: string =
-    `Mutation testing  [:bar] :percent (ETC :etas) :tested/:total tested (:survived survived)`;
+  const progressBarContent: string = `Mutation testing  [:bar] :percent (ETC :etc) :tested/:total tested (:survived survived)`;
 
   beforeEach(() => {
-    sut = new ProgressReporter();
     sandbox = sinon.createSandbox();
+    sandbox.useFakeTimers();
+
+    sut = new ProgressReporter();
+
     progressBar = mock(ProgressBar);
     sandbox.stub(progressBarModule, 'default').returns(progressBar);
   });
@@ -78,4 +85,34 @@ describe('ProgressReporter', () => {
       expect(progressBar.tick).to.have.been.calledWithMatch(progressBarTickTokens);
     });
   });
+
+  describe('ProgressBar estimate time', () => {
+    beforeEach(() => {
+      sut.onAllMutantsMatchedWithTests([matchedMutant(1), matchedMutant(1)]);
+    });
+
+    it('should show to an estimate of "10s" in the progressBar after ten seconds and 1 mutants tested', () => {
+      sandbox.clock.tick(TEN_SECONDS);
+
+      sut.onMutantTested(mutantResult({ status: MutantStatus.Killed }));
+
+      expect(progressBar.tick).to.have.been.calledWithMatch({ etc: '10s' });
+    });
+
+    it('should show to an estimate of "1m, 40s" in the progressBar after hundred seconds and 1 mutants tested', () => {
+      sandbox.clock.tick(HUNDRED_SECONDS);
+
+      sut.onMutantTested(mutantResult({ status: MutantStatus.Killed }));
+
+      expect(progressBar.tick).to.have.been.calledWithMatch({ etc: '1m, 40s' });
+    });
+
+    it('should show to an estimate of "2h, 46m, 40s" in the progressBar after ten thousand seconds and 1 mutants tested', () => {
+      sandbox.clock.tick(TEN_THOUSAND_SECONDS);
+
+      sut.onMutantTested(mutantResult({ status: MutantStatus.Killed }));
+
+      expect(progressBar.tick).to.have.been.calledWithMatch({ etc: '2h, 46m, 40s' });
+    });
+  });
 });