Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Initial test run): start timing the test run when logging that the run is starting #2496

Merged
merged 3 commits into from
Sep 28, 2020
Merged

feat(Initial test run): start timing the test run when logging that the run is starting #2496

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d5f71ed
feat(Initial test run): start timing the test run when logging that t…
simondel Sep 25, 2020
054b6da
feat(timing): Log initial testrun time as time since the run started
Sep 28, 2020
8c7024f
Add unit test
nicojs Sep 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/src/process/3-DryRunExecutor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ export class DryRunExecutor {
.provideValue(coreTokens.testRunnerConcurrencyTokens, this.concurrencyTokenProvider.testRunnerToken$)
.provideFactory(coreTokens.testRunnerPool, createTestRunnerPool);
const testRunnerPool = testRunnerInjector.resolve(coreTokens.testRunnerPool);
this.timer.mark(INITIAL_TEST_RUN_MARKER);
this.log.info('Starting initial test run. This may take a while.');
const testRunner = await testRunnerPool.worker$.pipe(first()).toPromise();
const { dryRunResult, grossTimeMS } = await this.timeDryRun(testRunner);
Expand Down Expand Up @@ -122,7 +123,6 @@ export class DryRunExecutor {
throw new Error('Something went wrong in the initial test run');
}
private async timeDryRun(testRunner: TestRunner): Promise<{ dryRunResult: DryRunResult; grossTimeMS: number }> {
this.timer.mark(INITIAL_TEST_RUN_MARKER);
const dryRunResult = await testRunner.dryRun({ timeout: INITIAL_RUN_TIMEOUT, coverageAnalysis: this.options.coverageAnalysis });
const grossTimeMS = this.timer.elapsedMs(INITIAL_TEST_RUN_MARKER);
return { dryRunResult, grossTimeMS };
Expand Down