Add buildCommand question when running `stryker init` #3213

radiantly · 2021-10-19T12:46:52Z

Background

On running stryker init, the user is prompted for a custom build command to run provided that they do not choose the jest test runner.

Fixes #3211

nicojs

Looks good! Could you also add 3 unit tests? One for jest, one for not-jest but without a build command and 1 for not-jest with a build command?

The unit tests for the initializer are all situated in test/unit/initializer/stryker-initializer.spec.ts

packages/core/src/initializer/stryker-inquirer.ts

Co-authored-by: Nico Jansen <[email protected]>

nicojs

Thanks for the great PR 👍. Just a small remark, please let me know if you don't agree or don't have the time to implement it.

packages/core/test/unit/initializer/stryker-initializer.spec.ts

feat(core): add buildCommand to stryker init

ad6b4a6

nicojs requested changes Oct 19, 2021

View reviewed changes

packages/core/src/initializer/stryker-inquirer.ts Outdated Show resolved Hide resolved

radiantly and others added 2 commits October 19, 2021 21:16

fix: add tests

8a8c3e5

fix: edit buildCommand prompt text

4cd2cb7

Co-authored-by: Nico Jansen <[email protected]>

radiantly requested a review from nicojs October 19, 2021 16:45

nicojs requested changes Oct 20, 2021

View reviewed changes

packages/core/test/unit/initializer/stryker-initializer.spec.ts Outdated Show resolved Hide resolved

nicojs added the hacktoberfest-accepted label Oct 20, 2021

Only write buildCommand to config when non-empty

b0d7d72

radiantly requested a review from nicojs October 20, 2021 16:56

Fix small typo

d7fd5cf

nicojs approved these changes Oct 25, 2021

View reviewed changes

nicojs enabled auto-merge (squash) October 25, 2021 07:30

nicojs merged commit b9d5980 into stryker-mutator:master Oct 25, 2021