-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(reporting): Make links clickable in terminals that support Ansi magic #1936
Conversation
Hmm, the failing test is flaky.. it succeeds when it's run individual, but fails when running all tests together... |
@eNeRGy164 are you looking into the flaky test? I'd very much like to merge this 🙌 |
Yes, already did have a quick look, but did not find a solution yet |
@richardwerkman Go ahead :) |
@rouke-broersma now you introduced conflicts again |:( :) |
😅😅 |
You can rebuild the packages.lock files by building the project with the latests changes included 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason the report path is printed over two distinct lines, does spectre.console enforce some kinda line length?
Your json report has been generated at:
D:\a\1\s\integrationtest\TargetProjects\NetCoreTestProject.XUnit\StrykerOutput\2
022-03-04.22-22-53\reports\mutation-report.json
Hint: by passing "--open-report or -o" the report will open automatically once
Stryker is done.
Your html report has been generated at:
D:\a\1\s\integrationtest\TargetProjects\NetCoreTestProject.XUnit\StrykerOutput\2
022-03-04.22-22-53\reports\mutation-report.html
You can open it in your browser of choice.
From a quick search it seems like Spectre.Console out-detects max console width, that makes me think if it cannot be auto detected a max-width of 80 is chosen (legacy terminal character limit). On the one hand this seems fine, on the other hand in a CI pipeline it's not really necessary to cut off a filepath.
It seems to also affect the table and file tree reports in azure devops output making them less usefull because the content is simply cut off in some cases or placed on new lines in others.
All mutants have been tested, and your mutation score has been calculated
╭────────────────────────────┬───────┬───────┬────────┬─────────┬───────┬──────╮
│ File │ % │ # │ # │ # │ # no │ # │
│ │ score │ kill… │ timeo… │ surviv… │ cov │ err… │
├────────────────────────────┼───────┼───────┼────────┼─────────┼───────┼──────┤
│ All files │ 16.92 │ 9 │ 2 │ 92 │ 50 │ 2 │
│ Csharp7.cs │ 0.00 │ 0 │ 0 │ 1 │ 1 │ 0 │
│ Csharp8.cs │ 0.00 │ 0 │ 0 │ 14 │ 6 │ 0 │
│ Endlessloop.cs │ 40.00 │ 0 │ 2 │ 3 │ 1 │ 0 │
│ LinqMagic.cs │ 0.00 │ 0 │ 0 │ 17 │ 15 │ 0 │
│ Math\Calc\DummyCalc.cs │ 0.00 │ 0 │ 0 │ 13 │ 13 │ 0 │
│ Math\DummyMath.cs │ 66.67 │ 2 │ 0 │ 1 │ 0 │ 0 │
│ Person.cs │ N/A │ 0 │ 0 │ 9 │ 0 │ 0 │
│ String\StringMagic.cs │ 0.00 │ 0 │ 0 │ 17 │ 13 │ 2 │
│ String\StringReplaceChain. │ 0.00 │ 0 │ 0 │ 8 │ 1 │ 0 │
│ cs │ │ │ │ │ │ │
│ Student.cs │ 75.00 │ 3 │ 0 │ 9 │ 0 │ 0 │
│ UnsafeCode.cs │ 100.0 │ 4 │ 0 │ 0 │ 0 │ 0 │
│ │ 0 │ │ │ │ │ │
╰────────────────────────────┴───────┴───────┴────────┴─────────┴───────┴──────╯
I think we can accept fixing this in a new issue though it only affects CI runs and is probably what you want in a non-CI scenario.
src/Stryker.Core/Stryker.Core/Reporters/HtmlReporter/HtmlReporter.cs
Outdated
Show resolved
Hide resolved
…port in case the terminal does support uri's natively
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
After discussion in #1394
Crayon
withSpectre.Console
I think Spectre.Console removes a lot of clutter when generating the table/tree output.
Allows for more fancy stuff in the future, and is well maintained.
I didn't replace the progress bar implementation at this moment in time.
Output using the changed code: