Put back position:relative on mod/pop. #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to fix it. This breaks the newFormattingContext rule, but it is localized on pop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
mod/pop is broken in the current master - see the examples in mod_doc.html . This seems to be a direct consequence of the previous "newFormattingContext" merge, in which the .mod .inner element lost its "display: inline" property.
I've been studying this for 2 evenings and I think that the strategy used in mod/pop can't be used without having an relatively-positioned inner div; it just relies too much on that. In my opinion, there are only two courses of action:
On this pull request I'm making it relatively positioned. I humbly suggest that this gets merged into master, at least while a better solution is found.