-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
separate thumbnail generation and other job manager improvements #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 297fbf1.
Merged
aaronleopold
changed the title
[DRAFT] separate thumbnail generation and other job manager improvements
separate thumbnail generation and other job manager improvements
Aug 19, 2023
A lot was added since making this PR:
One thing that I've made a note to fix is when doing a batch scan it seems to hang on the last book, but in reality the updates just stop while the server generates the massive SQL operations. I need to add a simple event to tell the client 'hey, I'm inserting stuff now' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've restructured the job manager a little bit to make queuing jobs a bit more intuitive. It should also set it up to be a little bit easier to make jobs more stateful at some point down the road.
Thumbnail jobs are now separate from scans, and are queued once a scan is finishing up (assuming a thumbnail configuration is present). This is somewhat dumb at the moment in that you cannot regenerate thumbnails yet, but I will add that in either before or after this PR merges.