Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Book completed toggle button and fix read again button #208

Merged
merged 8 commits into from
Dec 6, 2023
Merged

✨ Book completed toggle button and fix read again button #208

merged 8 commits into from
Dec 6, 2023

Conversation

aaronleopold
Copy link
Collaborator

Resolves #206
Resolves #204

@aaronleopold
🚧 Start API for manually setting completion status
3b406ae 
Defines most of the API work towards #204
@aaronleopold
Merge remote-tracking branch 'origin/develop' into al/manual-progress…
313d6a3 
…-mutation
@aaronleopold
🐛 Fix Read again not starting from start
4b4ef57 
Fix for #206

🚧 Go to first page when clicking Read again

Completed at does not get reset yet

Run codegen
@aaronleopold
✨ Book completed toggle button
39483a6 
Added a button to toggle the completed state for a book (#204)
@aaronleopold
Fix lint quickly
cb97c0f
@aaronleopold
🐛 Fix prefetch media handler
d46a18a 
The prefetchMedia function was storing the raw response as a Media object, which broke LOTS of things
@aaronleopold
🐛 Fix prefetch series handler
509f323 
The prefetchSeries function was storing the raw response as a Series object
@aaronleopold
Adjust reset progress state
5231b10
@aaronleopold aaronleopold changed the title [WIP] ✨ Book completed toggle button and fix read again button ✨ Book completed toggle button and fix read again button Dec 6, 2023
@aaronleopold
Copy link
Collaborator Author

This should be good to merge once CI passes, a couple notes:

  • I added endpoints to query for a book's completion status AND a series' completion status
  • I added an endpoint for toggling a book's completion status
  • I added an unimplemented endpoint for toggling a series' completion status
    • This will eventually mark each book in the series as read. I'll try and add that in sometime soon
  • Caught and fixed a couple of bugs related to prefetching, primarily the prefetch media and series queries. The TLDR; for those is the raw response, rather than just the data, was being cached, and the invalid type caused UI issues/errors

@aaronleopold aaronleopold marked this pull request as ready for review December 6, 2023 01:28
@aaronleopold aaronleopold merged commit 684a893 into develop Dec 6, 2023
7 checks passed
@aaronleopold aaronleopold deleted the al/manual-progress-mutation branch December 6, 2023 01:32
@aaronleopold aaronleopold mentioned this pull request Dec 6, 2023
Closed
JMicheli pushed a commit to JMicheli/stump that referenced this pull request Dec 8, 2023
@aaronleopold @JMicheli
✨ Book completed toggle button and fix read again button (stumpapp#208)
4d016c3 
* 🚧 Start API for manually setting completion status

Defines most of the API work towards stumpapp#204

* 🐛 Fix Read again not starting from start

Fix for stumpapp#206

🚧 Go to first page when clicking Read again

Completed at does not get reset yet

Run codegen

* ✨ Book completed toggle button

Added a button to toggle the completed state for a book (stumpapp#204)

* Fix lint quickly

* 🐛 Fix prefetch media handler

The prefetchMedia function was storing the raw response as a Media object, which broke LOTS of things

* 🐛 Fix prefetch series handler

The prefetchSeries function was storing the raw response as a Series object

* Adjust reset progress state
@aaronleopold aaronleopold mentioned this pull request Feb 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aaronleopold