Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ Refactor image readers with more shared logic #285

Merged
merged 6 commits into from
Feb 25, 2024
Merged

♻️ Refactor image readers with more shared logic #285

merged 6 commits into from
Feb 25, 2024

Conversation

aaronleopold
Copy link
Collaborator

Resolves #210
Fixes #283

  • Unify some of the rendering and logic for the image-based readers, allowing for more seamless transitions between paged vs continuous reader(s)
  • Updated some VERY old OPDS code which caused a bug using Yomu
    • Side note: I would like to do a rough pass through all of the OPDS logic before 0.1.0, as it is generally the oldest code in the repo
  • Added local preferences for adjusting preload options in the image readers. If people would rather this be persisted to the DB I can adjust it
  • Adjusted a few misc styles

@aaronleopold aaronleopold marked this pull request as ready for review February 25, 2024 22:22
@aaronleopold aaronleopold merged commit a2a49b7 into experimental Feb 25, 2024
3 checks passed
@aaronleopold aaronleopold mentioned this pull request Apr 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aaronleopold