✨ Email to device #296
Merged
✨ Email to device #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for configuring an email client and encrypting secrets associated with a notifier (if necessary)
|
I was able to get TLS working with gmail, didn't test other common SMTP providers (e.g. outlook). I'll aim to merge this in to get it in |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #132
Resolves #184
PR adds emailing functionality to the core via a new
emailcrate and corresponding API/core work:email:sendto send to any registered email aliasesemail:arbitrary_sendto send to any email address that is not forbiddenI'm currently facing issues getting the TLS Google port for SMTP to work. I'll likely spend more time tinkering, since I am going to be letting this sit for other misc testing anyways, but I might yeet that off to a future improvement to focus on other priorities.
Reminder to future self: push the migration once confident the schema changes are finalized ✅