Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨 Update docker-compose file example in docs to remove version #373

Merged

Conversation

fehwalker
Copy link
Contributor

Current docker compose file standard no longer uses the version element and having it throws a warning.

WARN[0000] ./stump/docker-compose.yml: the attribute `version` is obsolete, it will be ignored, please remove it to avoid potential confusion

https://docs.docker.com/compose/compose-file/04-version-and-name/

Updated the example in the docs to remove version.

* let me know if you want an issue opened as well, but this seemed tiny.

@aaronleopold aaronleopold changed the title Update docker-compose file example in docs to remove version 🔨 Update docker-compose file example in docs to remove version Jul 27, 2024
Copy link
Collaborator

@aaronleopold aaronleopold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@aaronleopold aaronleopold enabled auto-merge (squash) July 27, 2024 16:50
Copy link

codecov bot commented Jul 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

@aaronleopold aaronleopold merged commit 6bba9f9 into stumpapp:develop Jul 27, 2024
5 checks passed
@fehwalker fehwalker deleted the update-docker-compose-example branch July 27, 2024 17:14
@aaronleopold aaronleopold mentioned this pull request Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants