-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix various thumbnail generation issues #381
Conversation
There are a good amount of other changes in this diff, e.g. upgrading the rust version, some crates, clippy fixes, etc.
I'm aiming to have time tomorrow to re-validate the fixes in this PR, then I'll merge it in. I'll start prepping the next versioned release within a week or so after that point. |
I just tested the following without issue:
Added a small fix to correctly render the library settings form according to fresh update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks awesome - no issues on my end when testing.
I have a minor suggestion in my review comments both otherwise LGTM.
Co-authored-by: Joseph Micheli <[email protected]>
Co-authored-by: Joseph Micheli <[email protected]>
Co-authored-by: Joseph Micheli <[email protected]>
There are a good amount of other changes in this diff, e.g. upgrading the rust version, some crates, clippy fixes, etc:
1.79.0
(one minor behind the very recent stable). Multiple lint issues surfaced after the upgradeProcessorError
to (eventually) replace theFileError
usage throughout the image processors. This was mostly because not all errors during image processing are file errors, and it would feel out of place to add them toFileError
GenericImageProcessor
behaviorWebpProcessor
behaviorvalidate
fn to theImageProcessorOptions
struct to enforce valid configurations server-sideremove_thumbnails_of_type
and replace the single usage withremove_thumbnails
to fix the issue where regenerating/removing thumbnails doesn't clean up thumbnails of differing formats than the configured format