Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix emailer form validation and update endpoint #430

Merged
merged 5 commits into from
Sep 1, 2024

Conversation

aaronleopold
Copy link
Collaborator

Resolves #429

The registering of numeric fields was not correct, and so it was parsing them incorrectly triggering the validation error to pop up.

I've taken this as an opportunity to add jest into the frontend app, something that frankly should have been done a LONG time ago. In my spare time, and while developing other features, I'll try to add tests bit by bit to improve overall coverage to reduce small little bugs like this.

Also, the delete emailer functionality (client-side) was never hooked up. So I went ahead and added the hookups

@aaronleopold aaronleopold marked this pull request as ready for review September 1, 2024 17:41
Copy link

codecov bot commented Sep 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 46 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
apps/server/src/routers/api/v1/emailer.rs 0.00% 26 Missing ⚠️
core/src/db/entity/emailer/entity.rs 0.00% 13 Missing ⚠️
crates/email/src/emailer.rs 0.00% 7 Missing ⚠️
Files with missing lines Coverage Δ
core/src/error.rs 0.00% <ø> (ø)
crates/email/src/error.rs 0.00% <ø> (ø)
crates/email/src/emailer.rs 0.00% <0.00%> (ø)
core/src/db/entity/emailer/entity.rs 0.00% <0.00%> (ø)
apps/server/src/routers/api/v1/emailer.rs 0.00% <0.00%> (ø)

@aaronleopold aaronleopold changed the title 🐛 Fix emailer form validation 🐛 Fix emailer form validation and update endpoint Sep 1, 2024
@aaronleopold aaronleopold merged commit ce173a2 into develop Sep 1, 2024
8 checks passed
@aaronleopold aaronleopold deleted the al/fix-emailer-form branch September 1, 2024 19:37
@aaronleopold aaronleopold mentioned this pull request Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant