Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix max-depth for collection-priority libraries #432

Merged
merged 3 commits into from
Sep 2, 2024

Conversation

aaronleopold
Copy link
Collaborator

Fixes a bug introduced from the fix which aimed to correct a regression in the scanner lol #423

The crux of the issue is outlined in the code to (hopefully) prevent a similar bug from slipping through the cracks again:

If the library is collection-priority, any child directories are 'ignored' and their files are part of / folded into the top-most folder (series).
If the library is not collection-priority, each subdirectory is its own series.
Therefore, we only scan one level deep when walking a series whose library is not collection-priority to avoid scanning duplicates which are part of other series

Fixes a bug introduced from the fix which aimed to correct a regression in the scanner lol #423
@aaronleopold aaronleopold marked this pull request as ready for review September 1, 2024 23:48
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
core/src/filesystem/scanner/series_scan_job.rs 0.00% 7 Missing ⚠️
core/src/filesystem/scanner/library_scan_job.rs 0.00% 6 Missing ⚠️
Files with missing lines Coverage Δ
core/src/filesystem/scanner/library_scan_job.rs 0.00% <0.00%> (ø)
core/src/filesystem/scanner/series_scan_job.rs 0.00% <0.00%> (ø)

@aaronleopold aaronleopold merged commit 558721a into develop Sep 2, 2024
8 checks passed
@aaronleopold aaronleopold mentioned this pull request Sep 6, 2024
@aaronleopold aaronleopold deleted the al/fix-collection-priority-scanning branch September 12, 2024 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant