-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add image reader experience options #453
Conversation
Alright, I think this is almost ready to go. There are a few things I want to highlight as things I'll have to either improve or fix as follow-ups:
There is one other issue that I'd like to tackle before merge where the bottom bar preview is too "strict" and will scroll you back as you try to navigate ahead. Otherwise, I'm anxious to get this out for further testing. My tentative plan moving forward is:
|
I've fixed this for the most part, so I am going to merge this in shortly. I don't think the UX is perfect TBH, but am eager to get it out there and tested |
Resolves #384
Resolves #391
Resolves #437
This PR implements a few image-based reader features:
You will be able to configure defaults for the reading experience on a per-library basis, and override any individual setting per-book.
I've sneaked in a few other changes, as well:
There are some cleanup tasks remaining, and I'd like to add the corresponding library configuration I mentioned above in the settings pages, and then this should be ready to go. I'm aiming for sometime next week