🚨 Run clippy pedantic

[JMicheli]

This is a housekeeping PR. I went into the roots of the core and server crates, enabled clippy::pedantic, and fixed anything that seemed sensible to fix. I think the result is nice, lots of little readability and consistency fixes. Plus it was relaxing.

There were even a few instances where parameters in functions could become references, which could theoretically improve performance but won't because it was like 4 string manipulation functions.

Passes tests and runs fine for me after as well.

[aaronleopold]

This is awesome, thank you! I glossed through the change-set, but I'll trust clippy on this one

Plus it was relaxing

I love this, I also enjoy clippy doing its thing

[codecov]

Codecov Report

Attention: Patch coverage is 16.11842% with 255 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
apps/server/src/routers/api/v1/library.rs	0.00%	21 Missing ⚠️
apps/server/src/routers/api/v1/book_club.rs	0.00%	19 Missing ⚠️
apps/server/src/routers/api/v1/media.rs	0.00%	18 Missing ⚠️
apps/server/src/routers/api/v1/user.rs	0.00%	14 Missing ⚠️
core/src/filesystem/media/format/epub.rs	12.50%	14 Missing ⚠️
apps/server/src/routers/api/v1/series.rs	0.00%	13 Missing ⚠️
core/src/db/entity/metadata/media_metadata.rs	20.00%	8 Missing ⚠️
core/src/filesystem/scanner/library_scan_job.rs	0.00%	8 Missing ⚠️
core/src/opds/v1_2/entry.rs	0.00%	8 Missing ⚠️
core/src/db/query/pagination.rs	0.00%	7 Missing ⚠️
... and 49 more

Files with missing lines	Coverage Δ
apps/server/src/errors.rs	26.57% <ø> (ø)
apps/server/src/routers/spa.rs	9.67% <100.00%> (ø)
apps/server/src/routers/sse.rs	0.00% <ø> (ø)
core/src/context.rs	21.73% <ø> (ø)
core/src/db/entity/epub.rs	0.00% <ø> (ø)
core/src/db/entity/log.rs	0.00% <ø> (ø)
core/src/db/entity/metadata/page_dimension.rs	92.25% <100.00%> (ø)
core/src/db/entity/series/entity.rs	0.00% <ø> (ø)
core/src/db/query/ordering.rs	8.04% <ø> (ø)
core/src/filesystem/archive.rs	97.77% <100.00%> (ø)
... and 74 more