Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cookie not being set causing infinite loop #88

Merged
merged 4 commits into from
Feb 12, 2023

Conversation

aaronleopold
Copy link
Collaborator

@aaronleopold aaronleopold commented Feb 12, 2023

  • Logic added to append the local IP addresses to allowed origins by default
  • Removed the secure flag being set for the session config, which caused the browser to block the cookie being set
    • I'd like to see if I can make this configurable, but that will have to be tackled once I test HTTPS configs

I'll probably try tackling this small but really annoying bug I found while at the airport before merging this in.

@aaronleopold
Copy link
Collaborator Author

I'll probably try tackling this small but really annoying bug I found while at the airport before merging this in.

Fixed 🚀 see here

@aaronleopold aaronleopold merged commit c3fe603 into develop Feb 12, 2023
@aaronleopold aaronleopold deleted the al/cors-infinite-redirect branch February 12, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant