Add _measure_time time function

[reahaas]

No description provided.

[reahaas]

A function that get the function to execute and an argument, call the function with the given argument and return the time of executions.

[rooterkyberian]

make it a contextmanager - it will be much easier to use

two alternative implementations:

from typing import Optional


class MeasureTime:
    def __init__(self):
        self.start = None
        self.stop = None

    @staticmethod
    def time() -> float:
        return time.time()

    @property
    def elapsed(self) -> Optional[float]:
        if self.start is None:
            return None
        return (self.stop or self.time()) - self.start

    def __enter__(self):
        self.start = self.time()
        return self

    def __exit__(self, exc_type, exc_val, exc_tb):
        self.stop = self.time()

mt = MeasureTime()
with mt:
    func(args)
print(f"func call lasted {mt.elapsed}s")

import contextlib

@contextlib.contextmanager
def measure_time():
    start = time.time()
    def elapsed():
        return time.time() - start

    yield elapsed

with measure_time() as elapsed:
    func(args)
    print(f"func call lasted {elapsed()}s")

[reahaas]

Thanks,
That great, I chose the second implementation you proposed, it nicer.

[reahaas]

After some struggling with the second approach, moved to the first one (define a class).

[reahaas]

Log the execution time.

[reahaas]

Log the execution time.

[rooterkyberian]

please make sure make check passes on your machine
from what I have seen the automated formatter of the code was not run

[rooterkyberian]

make it a contextmanager - it will be much easier to use

two alternative implementations:

from typing import Optional


class MeasureTime:
    def __init__(self):
        self.start = None
        self.stop = None

    @staticmethod
    def time() -> float:
        return time.time()

    @property
    def elapsed(self) -> Optional[float]:
        if self.start is None:
            return None
        return (self.stop or self.time()) - self.start

    def __enter__(self):
        self.start = self.time()
        return self

    def __exit__(self, exc_type, exc_val, exc_tb):
        self.stop = self.time()

mt = MeasureTime()
with mt:
    func(args)
print(f"func call lasted {mt.elapsed}s")

import contextlib

@contextlib.contextmanager
def measure_time():
    start = time.time()
    def elapsed():
        return time.time() - start

    yield elapsed

with measure_time() as elapsed:
    func(args)
    print(f"func call lasted {elapsed()}s")

[reahaas]

I used here an f-string to pass content to the logger, although the rest of the file usage %r style. Is it ok?

[rooterkyberian]

know I think about it - no, please use %-format style

my reason for sticking with %-format style for logging is the way tools like sentry handle error log aggregation - as it integrates with logging on Python level it can easily aggregate stuff using the same format string. If you use f"" formatting each message looks like a different one to it and it cannot aggregate.

So yea, %-format is not as nice, but preventing duplicates in Sentry is much bigger concern to me.

[reahaas]

Fixed.

[rooterkyberian]

love it
I'm going to squash commits to have a cleaner history or you can do it yourself if you want. I will merge this PR after I'm done with my work.

btw https://hacktoberfest.digitalocean.com/ is on and you are off to a good start ;)

[reahaas]

you are off to a good start

Thanks, I just joined the challenge 🥇