-
-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue #317 #319
Fix issue #317 #319
Conversation
@marcosvega91 thanks for PRing, could you rebase against latest changes? |
d1361e0
to
507f2cf
Compare
I have rebased the branch :) |
@probablyup is there anything that can be done to speed up getting this merged? the issue is pretty annoying, because it effectively renders repeated snapshotting of the same nodes useless... |
Kindly ask if this PR can be merged? |
It has merge conflicts at the moment |
@marcosvega91 any chance you could rebase again? Or would you prefer somebody else take over the PR? |
After the first render the node are marked with KEY property and calling rerender function of react-testing-library the test function will return false preventing the print to work as expected
507f2cf
to
bf77d30
Compare
I have rebased the branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you!
After the first render the node are marked with KEY property.
Calling the rerender function of RTL the nodes remain marked and the print function will never call again.