Fix issue #317 #319
Merged
Fix issue #317 #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marcosvega91 thanks for PRing, could you rebase against latest changes? |
marcosvega91
force-pushed
the
fix/rerendering_issue
branch
from
d1361e0
to
507f2cf
Compare
|
I have rebased the branch :) |
|
@probablyup is there anything that can be done to speed up getting this merged? the issue is pretty annoying, because it effectively renders repeated snapshotting of the same nodes useless... |
|
Kindly ask if this PR can be merged? |
|
It has merge conflicts at the moment |
|
@marcosvega91 any chance you could rebase again? Or would you prefer somebody else take over the PR? |
After the first render the node are marked with KEY property and calling rerender function of react-testing-library the test function will return false preventing the print to work as expected
marcosvega91
force-pushed
the
fix/rerendering_issue
branch
from
507f2cf
to
bf77d30
Compare
|
I have rebased the branch |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the first render the node are marked with KEY property.
Calling the rerender function of RTL the nodes remain marked and the print function will never call again.