Strip static class names from jest snapshot results #320
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to changes in styled-components v5, certain hashed class names are no longer being included in masterSheet, and therefore are not being serialized in snapshots by jest-styled-components.
Specifically, this occurs in the case where a styled component (
StyledDiv
) refers to another styled component (StyledDiv = styled(BaseDiv)
) and the base component (BaseDiv
) is not referenced in the component tree.This PR proposes stripping all static
sc-
prefixed classes from snapshot results as a brute force way to resolve this issue.Relevant styled-components doc:
https://styled-components.com/docs/advanced#referring-to-other-components
Relevant issues:
#307
#276