Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix native toHaveStyleRule to work with object style props #337

Merged
merged 2 commits into from
Nov 21, 2021
Merged

Fix native toHaveStyleRule to work with object style props #337

merged 2 commits into from
Nov 21, 2021

Conversation

sayav
Copy link
Contributor

@sayav sayav commented Aug 22, 2020 •
edited by quantizor
Loading

Fixes #336 #225

@sayav
Copy link
Contributor Author

sayav commented Sep 5, 2020

Any chance we can merge this one?

@ryanhyslop
Copy link

ryanhyslop commented Jul 19, 2021 •
edited
Loading

I've been stung by this issue today and hacked a similar fix into my local environment only to see this PR later.

Be good to see this get merged as could close this issue (#225)?

@quantizor
Copy link
Contributor

@sayav when you have time could you update this PR?

@quantizor quantizor enabled auto-merge (squash) November 21, 2021 15:03
@quantizor quantizor merged commit b01cd89 into styled-components:main Nov 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quantizor quantizor quantizor approved these changes

@jordanboaz jordanboaz jordanboaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Native toHaveStyleRule expects style prop to always be an array
4 participants
@sayav @ryanhyslop @quantizor @jordanboaz