-
-
Notifications
You must be signed in to change notification settings - Fork 934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix showing of incorrect missing package in customSyntax require handling #5763
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dlaub3 Thank you for creating this PR! I've suggested one idea for the usage of console.error()
.
Co-authored-by: Masafumi Koba <[email protected]>
remove console.error in favor of embedding the original error
@dlaub3 looks like it fails the CI Lint, do you want to try running |
This is the downside to applying changes via the GitHub UI. It should be good now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll defer back to @ybiquitous for a final review if needed, but on my end this LGTM! Thanks for the contribution 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dlaub3 Thank you. LGTM 👍🏼
|
Closes #5761
I'm not sure if the added
console.error
is beneficial. What are your thoughts?