Axisymmetric problems : Viscous source terms and generalised convective source terms and jacobian #1106

FlorianDm · 2020-11-16T16:29:30Z

Axisymmetric problems : Viscous source terms and generalised convective source terms and jacobian
See #1095

…erges

… ongoing

SU2_CFD/include/variables/CVariable.hpp

SU2_CFD/src/solvers/CSolver.cpp

SU2_CFD/include/variables/CVariable.hpp

WallyMaier · 2020-11-20T04:19:45Z

@FlorianDm, I was looking through another reference that @jtneedels passed to me. (http://eprints.gla.ac.uk/184394/1/184394.pdf)

If you are still struggling with the extension to RANS: On page 56, the stress terms are altered with a couple of terms. It may help...it may not.

…ode/SU2 into feature_axi_general_viscous

…ource

FlorianDm · 2020-11-20T12:28:01Z

@WallyMaier thank you. Interesting...

This reference reminded me to add the contribution of the turbulence kinetic energy (+2/3 v rho k) in the energy equation source (see page 10 equation 2.30, pdf page 37), so that's done.
This reference will be helpful If I get to do the axysimmetry source terms for k and omega (by comparing equations 2.31 and 2.31 to equations B.2 and B.3) but that will be in a separate PR. In fact I am getting good results for RANS already (although no time for a thorough validation)
In that reference they have also done what I did before and pulled out the primitive derivatives and neglected the viscosity gradient and then came up with the same axisymmetry momentum source terms so that is comforting. However, their energy source terms are different and that made me think. What we have now is according to the first reference, so it should be fine unless there is an error in it. I find it suspicious that both aux derivatives are wrt y and none wrt x given the that we have one wrt x and one wrt y in the momentum equation... Could it be AxiAuxVar_Grad_i[2][0] instead of AxiAuxVar_Grad_i[2][1] ? The impact on results is almost unnoticeable for my case. Otherwise we are done here I think.

@pcarruscag thanks for taking the time to review!

WallyMaier · 2020-11-20T23:17:49Z

SU2_CFD/include/variables/CVariable.hpp

   */
-  inline su2double GetAuxVar(unsigned long iPoint) const { return AuxVar(iPoint); }
+  inline su2double GetAuxVar(unsigned long iPoint, unsigned long iVar = 0) const { return AuxVar(iPoint,iVar); }


WallyMaier · 2020-11-20T23:20:44Z

SU2_CFD/src/solvers/CEulerSolver.cpp

+
+        if (yCoord > EPS){
+          su2double nu_v_on_y = Total_Viscosity*yVelocity/yCoord;
+          nodes->SetAuxVar(iPoint, 0, nu_v_on_y);


This is much cleaner...thanks!

WallyMaier · 2020-11-20T23:21:38Z

SU2_CFD/src/solvers/CSolver.cpp

@@ -1647,7 +1647,7 @@ void CSolver::GetCommCountAndType(const CConfig* config,
      MPI_TYPE         = COMM_TYPE_DOUBLE;
      break;
    case AUXVAR_GRADIENT:
-      COUNT_PER_POINT  = nDim;
+      COUNT_PER_POINT  = nDim*base_nodes->GetnAuxVar();


I know see how to do this properly 👍

…l_viscous

jtneedels · 2020-12-07T22:37:30Z

@WallyMaier and I ran some verification cases for axisymmetric verification (see attached slides). Results show good agreement between planar axisymmetric and 3D dimensional results.
AxisymmetricVerification.pptx

WallyMaier · 2020-12-08T03:01:27Z

Thanks @jtneedels for doing some testing. I think we saw some issues with the aerodynamic coefficient computations...but the pressure distributions looked good. This looks good to me. Ill leave it to @FlorianDm or @pcarruscag to make any final changes or suggestions.

Good work y'all!

aeroamit

@WallyMaier & @FlorianDm , I repeated the heat flux problem, I have posted earlier and seems like issue still persist (I showed earlier that this is not the problem with 2D case with symmetry BC but pops in with axisymmetric case). I am attaching the files here for reference ....
hflux_issue_axi_branch.pdf
heatflux_issue_old.pdf
case_files.zip

Also, let me know if I have missed out anything ......

WallyMaier · 2020-12-08T17:28:57Z

@aeroamit, interesting...Im think this could possibly be related to the computation of heatflux itself (with regards to the axisymmetric formulation). Judging from @jtneedels results, the Cp distributions look good. It could be the scaling factor applied to the heatflux?

Ill take a look

aeroamit · 2020-12-08T17:48:23Z

I have done some comparison cases for Cp distribution with axisymmetric formulation with older versions, they were matching well with commercial codes (I must say for the specific configurations I simulated, it somehow matched). This issue came into light while trying to obtain heat flux with axisymmetric formulation.
I will also try to run this axisymmetric case with some other code and compare....

bigfooted · 2020-12-08T18:25:52Z

@aeroamit What does temperature do? Could you compute the heat flux from the temperature in e.g. paraview? Is the root cause the computation of the energy equation or the computation of heat flux?

WallyMaier · 2020-12-08T23:05:06Z

@aeroamit, I ran the cases you had to take a look. While the residuals were "converged", the solution was not. There was a massive low temperature region along the body that took many more iterations to clean. The maximum Heat Flux was still ~6 w/m**2.

Can you post the reference for the 10.6 value?

aeroamit · 2020-12-09T17:58:56Z

@aeroamit What does temperature do? Could you compute the heat flux from the temperature in e.g. paraview? Is the root cause the computation of the energy equation or the computation of heat flux?

Hi @bigfooted, Temperature boundary condition for wall corresponds to Isothermal wall BC (cold wall condition). This condition is applied to obtain heat flux unlike adiabatic wall (no heat transfer).
The snapshot, I posted from ParaView shows heat flux variation with x. This is obtained directly from surface_flow.vtu. You can simply go to Filters -> Data Analysis -> Plot data and select Points_X for X Array and heat flux in variable. Regarding computing heat flux from temperature field, I am not sure, but ParaView is having calculator utility as well as option to compute gradient of unstructured grid (from there you can obtain temperature gradients in 3 directions).
Coming to last question, root cause of the problem - @WallyMaier has run the case yesterday, we will be posting some details soon.
Best
Amit

aeroamit

Hi @FlorianDm and @WallyMaier, I tried this branch and ran hemisphere (M=5) case as well as one more case. I found pressure distribution to be perfectly all right and matching well with alternate code. I did not observe any issue in the stagnation region for Cp distribution. We are good to go. Thanks for the fixes.. good job..

I am just attaching a file from heat flux computation issue case...
SU2_hflux_issue.pdf

WallyMaier and others added 8 commits October 8, 2020 13:05

implementing viscous axisymmetric terms for flow solver: runs but div…

cbe7143

…erges

fixing indices. axisymmetric is operational explicit. validation work…

aecffd5

… ongoing

fixing spaces, remove print statements

ddedd78

Merge remote-tracking branch 'origin/develop' into feature_axi

516da93

merge in develop and adding in Florian's work

d916436

Merge branch 'develop' into feature_axi_general_viscous

8b90694

correct viscous terms

a6a1992

space

ebef382

pr-triage bot added the PR: unreviewed label Nov 16, 2020

FlorianDm changed the title ~~Feature axi general viscous~~ Axisymmetric problems : Viscous source terms and generalised convective source terms and jacobian Nov 16, 2020

pcarruscag added the changelog:feature label Nov 17, 2020

pcarruscag reviewed Nov 18, 2020

View reviewed changes

SU2_CFD/include/variables/CVariable.hpp Outdated Show resolved Hide resolved

pcarruscag reviewed Nov 18, 2020

View reviewed changes

SU2_CFD/include/variables/CVariable.hpp Outdated Show resolved Hide resolved

SU2_CFD/src/solvers/CSolver.cpp Outdated Show resolved Hide resolved

SU2_CFD/include/variables/CVariable.hpp Outdated Show resolved Hide resolved

Merge branch 'develop' into feature_axi_general_viscous

52c032b

WallyMaier and others added 4 commits November 19, 2020 21:25

addressing PR comments

b6c3b02

fix and simplify source term in energy eq

b64bbd5

Merge branch 'feature_axi_general_viscous' of https://github.com/su2c…

690e918

…ode/SU2 into feature_axi_general_viscous

add contribution of turbulence kinetic energy to axisymmetry energy s…

0d2ded5

…ource

WallyMaier and others added 2 commits November 20, 2020 13:34

attempting to generalize the axisymm formulation

ccfbc28

fix compilation issues

e394f9b

WallyMaier reviewed Nov 20, 2020

View reviewed changes

WallyMaier and others added 5 commits November 23, 2020 09:31

Merge remote-tracking branch 'origin/develop' into feature_axi_genera…

7a73428

…l_viscous

Merge branch 'develop' into feature_axi_general_viscous

3eae110

allow laminar simulations

f61da0a

Merge branch 'develop' into feature_axi_general_viscous

048d37f

Merge branch 'develop' into feature_axi_general_viscous

ac408b5

WallyMaier approved these changes Dec 8, 2020

View reviewed changes

pr-triage bot added PR: reviewed-approved and removed PR: unreviewed labels Dec 8, 2020

aeroamit reviewed Dec 8, 2020

View reviewed changes

pcarruscag approved these changes Dec 8, 2020

View reviewed changes

Merge branch 'develop' into feature_axi_general_viscous

ec7839e

pr-triage bot added PR: unreviewed and removed PR: reviewed-approved labels Dec 11, 2020

aeroamit approved these changes Dec 13, 2020

View reviewed changes

pr-triage bot added PR: reviewed-approved and removed PR: unreviewed labels Dec 13, 2020

Merge branch 'develop' into feature_axi_general_viscous

b391d27

pr-triage bot added PR: unreviewed and removed PR: reviewed-approved labels Dec 14, 2020

WallyMaier merged commit 4669934 into develop Dec 14, 2020

WallyMaier deleted the feature_axi_general_viscous branch December 14, 2020 13:59

pr-triage bot added PR: merged and removed PR: unreviewed labels Dec 14, 2020

WallyMaier mentioned this pull request Dec 18, 2020

How does SU2 select the axis about which the simulation is treated to be axisymmetric? #1121

Closed

jtneedels mentioned this pull request Jan 12, 2021

Addition of Source Terms for NEMO Axisymmetric Flows #1162

Merged

5 tasks

FlorianDm mentioned this pull request Feb 8, 2021

Fix axi auxvargrad #1192

Merged

WallyMaier mentioned this pull request Jul 12, 2021

Fix for axisymmetric terms in NEMO + general NEMO updates #1326

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Axisymmetric problems : Viscous source terms and generalised convective source terms and jacobian #1106

Axisymmetric problems : Viscous source terms and generalised convective source terms and jacobian #1106

FlorianDm commented Nov 16, 2020

WallyMaier commented Nov 20, 2020 •

edited

Loading

FlorianDm commented Nov 20, 2020

WallyMaier Nov 20, 2020

WallyMaier Nov 20, 2020

WallyMaier Nov 20, 2020

jtneedels commented Dec 7, 2020

WallyMaier commented Dec 8, 2020

aeroamit left a comment •

edited

Loading

WallyMaier commented Dec 8, 2020

aeroamit commented Dec 8, 2020 •

edited

Loading

bigfooted commented Dec 8, 2020

WallyMaier commented Dec 8, 2020 •

edited

Loading

aeroamit commented Dec 9, 2020

aeroamit left a comment

Axisymmetric problems : Viscous source terms and generalised convective source terms and jacobian #1106

Axisymmetric problems : Viscous source terms and generalised convective source terms and jacobian #1106

Conversation

FlorianDm commented Nov 16, 2020

WallyMaier commented Nov 20, 2020 • edited Loading

FlorianDm commented Nov 20, 2020

WallyMaier Nov 20, 2020

Choose a reason for hiding this comment

WallyMaier Nov 20, 2020

Choose a reason for hiding this comment

WallyMaier Nov 20, 2020

Choose a reason for hiding this comment

jtneedels commented Dec 7, 2020

WallyMaier commented Dec 8, 2020

aeroamit left a comment • edited Loading

Choose a reason for hiding this comment

WallyMaier commented Dec 8, 2020

aeroamit commented Dec 8, 2020 • edited Loading

bigfooted commented Dec 8, 2020

WallyMaier commented Dec 8, 2020 • edited Loading

aeroamit commented Dec 9, 2020

aeroamit left a comment

Choose a reason for hiding this comment

WallyMaier commented Nov 20, 2020 •

edited

Loading

aeroamit left a comment •

edited

Loading

aeroamit commented Dec 8, 2020 •

edited

Loading

WallyMaier commented Dec 8, 2020 •

edited

Loading