Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SST-1994m consistent with literature and use 2003m by default #2062

Merged
merged 14 commits into from
Jul 3, 2023

Conversation

pcarruscag
Copy link
Member

Proposed Changes

Remove divergence terms from the source term, use 2003m by default.

Related Work

Closes #1551

PR Checklist

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@pcarruscag pcarruscag changed the title [WIP] Make SST-1994m consistent with literature and use 2003m by default Make SST-1994m consistent with literature and use 2003m by default Jul 3, 2023
@pcarruscag pcarruscag marked this pull request as ready for review July 3, 2023 02:03
Copy link
Contributor

@bigfooted bigfooted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, looks like we are following the nasa website description of the model now, and the residuals did not change by a lot so that's comforting.

@pcarruscag pcarruscag merged commit 9e9f1a2 into develop Jul 3, 2023
@pcarruscag pcarruscag deleted the sst_consistency branch July 3, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants