Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Aachen turbine test case #2293

Merged
merged 5 commits into from
Jun 27, 2024
Merged

Fix Aachen turbine test case #2293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
588da14
Fix for heap buffer overflow in CInterface.
jblueh Apr 3, 2024
9d50128
Merge branch 'develop' into fix_aachen_turbine
jblueh Jun 25, 2024
d428765
Rename input files for Aachen test case, temporarily update test case…
jblueh Jun 27, 2024
ef736ac
Update test values.
jblueh Jun 27, 2024
403c444
Re-enable address sanitzer testing.
jblueh Jun 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/regression.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ jobs:
uses: docker://ghcr.io/su2code/su2/test-su2:240320-1536
with:
# -t <Tutorials-branch> -c <Testcases-branch>
args: -b ${{github.ref}} -t develop -c develop -s ${{matrix.testscript}}
args: -b ${{github.ref}} -t develop -c fix_aachen_turbine -s ${{matrix.testscript}}
- name: Cleanup
uses: docker://ghcr.io/su2code/su2/test-su2:240320-1536
with:
Expand Down Expand Up @@ -261,7 +261,7 @@ jobs:
uses: docker://ghcr.io/su2code/su2/test-su2-tsan:240320-1536
with:
# -t <Tutorials-branch> -c <Testcases-branch>
args: -b ${{github.ref}} -t develop -c develop -s ${{matrix.testscript}} -a "--tsan"
args: -b ${{github.ref}} -t develop -c fix_aachen_turbine -s ${{matrix.testscript}} -a "--tsan"
- name: Cleanup
uses: docker://ghcr.io/su2code/su2/test-su2-tsan:240320-1536
with:
Expand Down Expand Up @@ -308,7 +308,7 @@ jobs:
uses: docker://ghcr.io/su2code/su2/test-su2-asan:240320-1536
with:
# -t <Tutorials-branch> -c <Testcases-branch>
args: -b ${{github.ref}} -t develop -c develop -s ${{matrix.testscript}} -a "--asan"
args: -b ${{github.ref}} -t develop -c fix_aachen_turbine -s ${{matrix.testscript}} -a "--asan"
- name: Cleanup
uses: docker://ghcr.io/su2code/su2/test-su2-asan:240320-1536
with:
Expand Down
2 changes: 1 addition & 1 deletion SU2_CFD/src/interfaces/CInterface.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ void CInterface::PreprocessAverage(CGeometry *donor_geometry, CGeometry *target_
for(iSpan = 1; iSpan <nSpanTarget-1; iSpan++){
dist = 10E+06;
dist2 = 10E+06;
for(jSpan = 0; jSpan < nSpanDonor;jSpan++){
for (jSpan = 1; jSpan < nSpanDonor - 1; jSpan++) {
test = abs(SpanValuesTarget[iSpan] - SpanValuesDonor[jSpan]);
test2 = abs(SpanValuesTarget[iSpan] - SpanValuesDonor[jSpan]);
if(test < dist && SpanValuesTarget[iSpan] > SpanValuesDonor[jSpan]){
Expand Down
2 changes: 1 addition & 1 deletion TestCases/parallel_regression.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1059,7 +1059,7 @@ def main():
Aachen_3D_restart.cfg_file = "aachen_3D_MP_restart.cfg"
Aachen_3D_restart.test_iter = 5
Aachen_3D_restart.enabled_with_asan = False
Aachen_3D_restart.test_vals = [-15.329206, -15.008622, -15.078888, -13.841072, -12.727840, -9.975729]
Aachen_3D_restart.test_vals = [-9.853215, -8.891480, -9.610418, -8.028579, -7.792957, -4.384186]
test_list.append(Aachen_3D_restart)

# Jones APU Turbocharger restart
Expand Down
3 changes: 1 addition & 2 deletions TestCases/serial_regression.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -860,8 +860,7 @@ def main():
Aachen_3D_restart.cfg_dir = "turbomachinery/Aachen_turbine"
Aachen_3D_restart.cfg_file = "aachen_3D_MP_restart.cfg"
Aachen_3D_restart.test_iter = 5
Aachen_3D_restart.enabled_with_asan = False
Aachen_3D_restart.test_vals = [-15.137167, -14.551444, -15.078894, -13.486154, -12.724891, -9.717612]
Aachen_3D_restart.test_vals = [-9.853207, -8.891479, -9.610411, -8.028566, -7.792947, -4.384177]
test_list.append(Aachen_3D_restart)

# Jones APU Turbocharger restart
Expand Down
4 changes: 2 additions & 2 deletions TestCases/turbomachinery/Aachen_turbine/aachen_3D_MP_restart.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,10 +316,10 @@ MESH_FORMAT= SU2
MESH_OUT_FILENAME= Aachen_3D_41_blade_coarse.su2
%
% Restart flow input file
SOLUTION_FILENAME= restart_flow.dat
SOLUTION_FILENAME= solution_flow.dat
%
% Restart adjoint input file
SOLUTION_ADJ_FILENAME= restart_adj.dat
SOLUTION_ADJ_FILENAME= solution_adj.dat
%
% Output file format
TABULAR_FORMAT= TECPLOT
Expand Down