[JavaScript] Added new regexp features #1416
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
November 10, 2017 10:44
…vascript-fancy-regexps
…es, added some tests.
…es, added some tests.
…1729/Packages into javascript-improved-regexps
|
Working on the conflict... |
|
I was just doing that now since I squashed the previous PR 🙂 |
|
Ah, OK. |
|
I ended up rebasing these on top of master and pushing directly there, just for a cleaner history. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #1415.
Adds support for:
s) flag.Also adds more detail to some existing constructs and fixes a couple of bugs.