Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make subctl a library #1660

Closed
wants to merge 1 commit into from
Closed

Make subctl a library #1660

wants to merge 1 commit into from

Conversation

Jaanki
Copy link
Contributor

@Jaanki Jaanki commented Nov 11, 2021

and provide a way to build it.

Signed-Off-By: Janki Chhatbar [email protected]

@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr1660/Jaanki/subctl_library
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

@Jaanki Jaanki marked this pull request as draft November 11, 2021 13:12
@Jaanki Jaanki self-assigned this Nov 11, 2021
@Jaanki Jaanki added this to the 0.12-m1 milestone Nov 11, 2021
@Jaanki Jaanki linked an issue Nov 11, 2021 that may be closed by this pull request
subctl should be refactored to a library, and make subctl the CLI of that library #1329
Closed
48 tasks
@Jaanki
Make subctl a library
35a1f90 
and provide a way to build it.

Signed-Off-By: Janki Chhatbar <[email protected]>
@Jaanki Jaanki closed this Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkolesnik mkolesnik Awaiting requested review from mkolesnik mkolesnik is a code owner

@Oats87 Oats87 Awaiting requested review from Oats87 Oats87 is a code owner

@skitt skitt Awaiting requested review from skitt skitt is a code owner

@sridhargaddam sridhargaddam Awaiting requested review from sridhargaddam sridhargaddam is a code owner

@tpantelis tpantelis Awaiting requested review from tpantelis tpantelis is a code owner

@vthapar vthapar Awaiting requested review from vthapar vthapar will be requested when the pull request is marked ready for review vthapar is a code owner

Assignees

@Jaanki Jaanki

Labels
None yet
Projects
None yet
Milestone
0.12-m1
Development

Successfully merging this pull request may close these issues.

subctl should be refactored to a library, and make subctl the CLI of that library
2 participants
@Jaanki @submariner-bot