Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move join to new subctl implementation #1699

Closed
wants to merge 1 commit into from
Closed

Move join to new subctl implementation #1699

wants to merge 1 commit into from

Conversation

Jaanki
Copy link
Contributor

@Jaanki Jaanki commented Dec 10, 2021 •
edited
Loading

Signed-Off-By: Janki Chhatbar [email protected]

  1. Move functions from join.go to helpers.go
  2. Make BrokerDetails and ClusterDetails subset of SubmarinerSpec and ServiceDiscoverySpec
  3. Move image* functions to internal/image package

@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr1699/Jaanki/move_coomands
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

@Jaanki Jaanki marked this pull request as draft December 10, 2021 13:51
skitt
skitt requested changes Dec 10, 2021
View reviewed changes
api/submariner/v1alpha1/servicediscovery_types.go Outdated
Comment on lines 33 to 34
BrokerDetails BrokerDetails `json:"broker_info"`
ClusterDetails ClusterDetails `json:"cluster_info"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change. You can share struct components but only by “inheriting” the struct. Any changes made here shouldn’t result in changes to the CRD YAMLs.

api/submariner/v1alpha1/submariner_types.go Outdated
BrokerK8sApiServerToken string `json:"brokerK8sApiServerToken"`
BrokerK8sCA string `json:"brokerK8sCA"`
BrokerK8sRemoteNamespace string `json:"brokerK8sRemoteNamespace"`
BrokerDetails BrokerDetails `json:"broker_details"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above, this is a breaking change, as is the ClusterDetails field below.

@Jaanki Jaanki marked this pull request as ready for review December 14, 2021 17:45
@stale
Copy link

stale bot commented Dec 28, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Dec 28, 2021
@skitt skitt removed the wontfix This will not be worked on label Jan 3, 2022
@tpantelis
Copy link
Contributor

I assume this is superseded by #1726?

@Jaanki Jaanki closed this Jan 4, 2022
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr1699/Jaanki/move_coomands]

@Jaanki
Copy link
Contributor Author

Jaanki commented Jan 4, 2022

Closed in favor of #1726

@Jaanki Jaanki deleted the move_coomands branch January 4, 2022 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skitt skitt skitt requested changes

@Oats87 Oats87 Awaiting requested review from Oats87 Oats87 is a code owner

@sridhargaddam sridhargaddam Awaiting requested review from sridhargaddam sridhargaddam is a code owner

@tpantelis tpantelis Awaiting requested review from tpantelis tpantelis is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jaanki @submariner-bot @tpantelis @skitt