Move pkg/utils/crds to pkg/crd #1743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpantelis
requested review from
Oats87,
skitt and
sridhargaddam
as code owners
|
🤖 Created branch: z_pr1743/tpantelis/move_crdutils |
tpantelis
force-pushed
the
move_crdutils
branch
from
07ea441
to
5ff0374
Compare
dfarrell07
approved these changes
Jan 6, 2022
tpantelis
force-pushed
the
move_crdutils
branch
from
5ff0374
to
be78886
Compare
I fixed them. |
tpantelis
force-pushed
the
move_crdutils
branch
from
be78886
to
d18ba1a
Compare
Also move the separate CRD CreateOrUpdate functions from utils to the Updater interface. Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
force-pushed
the
move_crdutils
branch
from
d18ba1a
to
60b591b
Compare
tpantelis
changed the title
skitt
approved these changes
Jan 7, 2022
Jaanki
approved these changes
Jan 7, 2022
|
🤖 Closed branches: [z_pr1743/tpantelis/move_crdutils] |
48 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also move the separate CRD
CreateOrUpdatefunctions from utils to theUpdaterinterface.