Deprecate colour codes, stop sending them to Submariner

[skitt]

These aren't used, let's drop them.

Depends on #1726.
Signed-off-by: Stephen Kitt [email protected]

[submariner-bot]

🤖 Created branch: z_pr1775/skitt/deprecate-colorcodes
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

[dfarrell07]

This might address part of a requirement for CNCF Incubation, btw.

Specifications must have at least one public reference implementation.

Since color codes might could be considered a spec, and they aren't really implemented (or at least we don't know if they work).

submariner-io/enhancements#58

[dfarrell07]

pkg/subctl/cmd/join.go:97:28: Error return value of (*github.com/spf13/pflag.FlagSet).MarkDeprecated is not checked (errcheck)
cmd.Flags().MarkDeprecated("colorcodes", "--colorcodes has no effect and is deprecated")

[tpantelis]

#1726 is also in flight.

[github-actions]

🎉 Great news! Looks like all the dependencies have been resolved:

• Move join to its own pkg #1726

💡 To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (:robot: ). Happy coding!

[submariner-bot]

🤖 Closed branches: [z_pr1775/skitt/deprecate-colorcodes]