-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy export to its own package #1817
Conversation
🤖 Created branch: z_pr1817/Jaanki/export |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - just one more minor comment.
Signed-off-by: Janki Chhatbar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor change on top of Tom’s request.
Using mcs-api.Install as AddToScheme is deprecated. https://pkg.go.dev/sigs.k8s.io/mcs-api/pkg/apis/v1alpha1#pkg-variables Signed-off-by: Janki Chhatbar <[email protected]>
🤖 Closed branches: [z_pr1817/Jaanki/export] |
To better understand the changes, review commit c822c36 against 2dc7317
Signed-off-by: Janki Chhatbar [email protected]