Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy export to its own package #1817

Merged
merged 3 commits into from
Feb 3, 2022
Merged

Copy export to its own package #1817

merged 3 commits into from
Feb 3, 2022

Conversation

Jaanki
Copy link
Contributor

@Jaanki Jaanki commented Feb 1, 2022

To better understand the changes, review commit c822c36 against 2dc7317

Signed-off-by: Janki Chhatbar [email protected]

@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr1817/Jaanki/export
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

@Jaanki Jaanki self-assigned this Feb 1, 2022
pkg/service/export.go Outdated Show resolved Hide resolved
pkg/service/export.go Outdated Show resolved Hide resolved
pkg/service/export.go Outdated Show resolved Hide resolved
pkg/service/export.go Outdated Show resolved Hide resolved
pkg/service/export.go Outdated Show resolved Hide resolved
pkg/service/export.go Outdated Show resolved Hide resolved
pkg/service/export.go Outdated Show resolved Hide resolved
Copy link
Contributor

@tpantelis tpantelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just one more minor comment.

cmd/subctl/export.go Outdated Show resolved Hide resolved
Signed-off-by: Janki Chhatbar <[email protected]>
cmd/subctl/export.go Outdated Show resolved Hide resolved
Copy link
Member

@skitt skitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change on top of Tom’s request.

cmd/subctl/export.go Outdated Show resolved Hide resolved
Using mcs-api.Install as AddToScheme is deprecated.
https://pkg.go.dev/sigs.k8s.io/mcs-api/pkg/apis/v1alpha1#pkg-variables

Signed-off-by: Janki Chhatbar <[email protected]>
@Jaanki Jaanki added the ready-to-test When a PR is ready for full E2E testing label Feb 3, 2022
@skitt skitt merged commit c73cef1 into submariner-io:devel Feb 3, 2022
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr1817/Jaanki/export]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-test When a PR is ready for full E2E testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants