Move unexport to new subctl implementation

[Jaanki]

Signed-off-by: Janki Chhatbar [email protected]

[submariner-bot]

🤖 Created branch: z_pr1983/Jaanki/unexport
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

[tpantelis]

I don't think this should be reported as success.

Suggested change

	if k8serrors.IsNotFound(err) {
	status.Success("Service %s not found", svcName)
	return nil
	}
	if k8serrors.IsNotFound(err) {
	status.Failure("Service %s/%s was not previously exported", namespace, svcName)
	return err
	}

[tpantelis]

The caller needs to pass the address of namespace. However I don't it makes sense to generalize the option name and description, ie we lose specific useful information, eg "namespace of the service to be exported" is better than "namespace to use". We could pass the name/description but I don't think it's worth it since this function just wraps one lint of code. Therefore, just inline cmd.Flags().StringVarP(...).

[dfarrell07]

Really weird MD link check error, happed again after re-run:

fatal: unsafe repository ('/github/workspace' is owned by someone else)
To add an exception for this directory, call:

	git config --global --add safe.directory /github/workspace

[submariner-bot]

🤖 Closed branches: [z_pr1983/Jaanki/unexport]