Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add accessibility linting #268

Open
Tracked by #58
dfarrell07 opened this issue Sep 10, 2020 · 7 comments
Open
Tracked by #58

Add accessibility linting #268

dfarrell07 opened this issue Sep 10, 2020 · 7 comments
Labels
automation cncf confirmed For issues and PRs which we definitely want (disables the stale bot) documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed priority:low size:small

Comments

@dfarrell07
Copy link
Member

Add linting to verify the accessibility of Submariner's website content.

We need to do some research on which tooling is best, but https://github.com/dequelabs/axe-core seems like a good toolkit, and the list of projects that consume it seems like good next place to look https://github.com/dequelabs/axe-core/blob/develop/doc/projects.md.
@dfarrell07 dfarrell07 added documentation Improvements or additions to documentation automation cncf labels Sep 10, 2020
@dfarrell07 dfarrell07 added this to the 0.7.0 milestone Sep 10, 2020
@dfarrell07 dfarrell07 self-assigned this Sep 10, 2020
@dfarrell07 dfarrell07 modified the milestones: 0.7.0, 0.8.0 Oct 7, 2020
@stale
Copy link

stale bot commented Dec 6, 2020

This issue has been automatically marked as stale because it has not had activity for 60 days. It will be closed if no further activity occurs. Please make a comment if this issue/pr is still valid. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Dec 6, 2020
@dfarrell07 dfarrell07 removed the wontfix This will not be worked on label Dec 7, 2020
@dfarrell07 dfarrell07 removed this from the 0.8.0 milestone Dec 14, 2020
@stale
Copy link

stale bot commented Feb 12, 2021

This issue has been automatically marked as stale because it has not had activity for 60 days. It will be closed if no further activity occurs. Please make a comment if this issue/pr is still valid. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Feb 12, 2021
@dfarrell07 dfarrell07 removed the wontfix This will not be worked on label Feb 12, 2021
@stale
Copy link

stale bot commented May 2, 2021

This issue has been automatically marked as stale because it has not had activity for 60 days. It will be closed if no further activity occurs. Please make a comment if this issue/pr is still valid. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label May 2, 2021
@tpantelis
Copy link
Contributor

bump

@stale stale bot removed the wontfix This will not be worked on label May 3, 2021
@stale
Copy link

stale bot commented Jul 2, 2021

This issue has been automatically marked as stale because it has not had activity for 60 days. It will be closed if no further activity occurs. Please make a comment if this issue/pr is still valid. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jul 2, 2021
@dfarrell07 dfarrell07 removed the wontfix This will not be worked on label Jul 2, 2021
@stale
Copy link

stale bot commented Oct 31, 2021

This issue has been automatically marked as stale because it has not had activity for 60 days. It will be closed if no further activity occurs. Please make a comment if this issue/pr is still valid. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Oct 31, 2021
@tpantelis tpantelis removed the wontfix This will not be worked on label Oct 31, 2021
@dfarrell07 dfarrell07 mentioned this issue Dec 4, 2021
Open
@dfarrell07
Copy link
Member Author

It would be good to have a check that fails on links with text "here", something like ![here](.

anfredette pushed a commit to anfredette/submariner-website that referenced this issue Jan 13, 2022
@tpantelis
E2E: make connection timeout configurable (submariner-io#268)
06332b9 
* E2E: make connection timeout configurable

Added 'connection-timeout' and `connection-attempts' test params.
Defaults are 6 and 10 for total timeout of 60 s.

Signed-off-by: Tom Pantelis <[email protected]>

* E2E: make timeout used by AwaitResultOrError configurable

Signed-off-by: Tom Pantelis <[email protected]>
@dfarrell07 dfarrell07 added the help wanted Extra attention is needed label Jan 18, 2022
@mkolesnik mkolesnik added the confirmed For issues and PRs which we definitely want (disables the stale bot) label Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
automation cncf confirmed For issues and PRs which we definitely want (disables the stale bot) documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed priority:low size:small
Projects
Backlog
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dfarrell07 @tpantelis @mkolesnik @maayanf24