Fix Go-based subctl install docs #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because we have `replace` statements in `submariner-operator/go.mod` to pin the K8s version, when run from outside of the submariner-operator repo `go install` declines to build `subctl` with: The go.mod file for the module providing named packages contains one or more replace directives. It must not contain directives that would cause it to be interpreted differently than if it were the main module. This issue is described upstream here: golang/go#44840 (comment) Signed-off-by: Daniel Farrell <[email protected]>
|
🤖 Created branch: z_pr622/dfarrell07/subctl_go_install |
|
✔️ Deploy Preview for elated-bell-2913d9 ready! 🔨 Explore the source changes: 6dc2b11 🔍 Inspect the deploy log: https://app.netlify.com/sites/elated-bell-2913d9/deploys/61aea705492dfe00076025a6 😎 Browse the preview: https://deploy-preview-622--elated-bell-2913d9.netlify.app |
dfarrell07
requested review from
Oats87,
skitt,
sridhargaddam and
tpantelis
as code owners
skitt
approved these changes
Dec 7, 2021
tpantelis
approved these changes
Dec 7, 2021
|
🤖 Closed branches: [z_pr622/dfarrell07/subctl_go_install] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we have
replacestatements insubmariner-operator/go.modtopin the K8s version, when run from outside of the submariner-operator
repo
go installdeclines to buildsubctlwith:This issue is described upstream here:
golang/go#44840 (comment)
Signed-off-by: Daniel Farrell [email protected]