Insert MSS clamping for traffic arriving services #1025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mangelajo
force-pushed
the
ovn-mss-clamping-services
branch
from
95e415f
to
22ce13a
Compare
mangelajo
added
blocker
skitt
approved these changes
Dec 14, 2020
|
one note after questions in slack: My plan is to implement PMTU discovery in 0.8.1 so we can use it here. Also... we need to go down to the OVN bug itself and get it fixed. |
OVN load balancing does not propagate fragment ICMPs down to the services, so when fragmentation becomes necessary the TCP stack of the service pod won't be able to detect this situation. Until this is fixed in OVN this workaround (to be enhanced later) will fix TCP. Fixes-Issue: submariner-io#1022 Signed-off-by: Miguel Angel Ajo <[email protected]>
mangelajo
force-pushed
the
ovn-mss-clamping-services
branch
from
22ce13a
to
8661d7d
Compare
tpantelis
approved these changes
Dec 14, 2020
sridhargaddam
approved these changes
Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OVN load balancing does not propagate fragment ICMPs down to the
services, so when fragmentation becomes necessary the TCP stack
of the service pod won't be able to detect this situation.
Until this is fixed in OVN this workaround (to be enhanced later)
will fix TCP.
Fixes-Issue: #1022
Signed-off-by: Miguel Angel Ajo [email protected]