Add a license-checking job #1326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skitt
requested review from
mangelajo,
mkolesnik,
Oats87 and
tpantelis
as code owners
|
🤖 Created branch: z_pr1326/skitt/licensecheck |
|
The failure is expected, because |
skitt
commented
May 12, 2021
skitt
commented
May 12, 2021
|
The tool and PR overall look great, ACK to your self-review -1 for now. |
skitt
added a commit
to skitt/submariner-operator
that referenced
this pull request
May 17, 2021
This uses https://github.com/uw-labs/lichen (see submariner-io/submariner#1326 for context). The references for the Allowlist and the approved exceptions are described in the lichen configuration file. Signed-off-by: Stephen Kitt <[email protected]>
skitt
added a commit
to skitt/lighthouse
that referenced
this pull request
May 17, 2021
This uses https://github.com/uw-labs/lichen (see submariner-io/submariner#1326 for context). The references for the Allowlist and the approved exceptions are described in the lichen configuration file. Signed-off-by: Stephen Kitt <[email protected]>
skitt
added a commit
to skitt/lighthouse
that referenced
this pull request
May 17, 2021
This uses https://github.com/uw-labs/lichen (see submariner-io/submariner#1326 for context). The references for the Allowlist and the approved exceptions are described in the lichen configuration file. Signed-off-by: Stephen Kitt <[email protected]>
skitt
added a commit
to skitt/submariner-operator
that referenced
this pull request
May 17, 2021
This uses https://github.com/uw-labs/lichen (see submariner-io/submariner#1326 for context). The references for the Allowlist and the approved exceptions are described in the lichen configuration file. Signed-off-by: Stephen Kitt <[email protected]>
skitt
added a commit
to skitt/submariner-operator
that referenced
this pull request
May 17, 2021
This uses https://github.com/uw-labs/lichen (see submariner-io/submariner#1326 for context). The references for the Allowlist and the approved exceptions are described in the lichen configuration file. Signed-off-by: Stephen Kitt <[email protected]>
skitt
added a commit
to skitt/lighthouse
that referenced
this pull request
May 17, 2021
This uses https://github.com/uw-labs/lichen (see submariner-io/submariner#1326 for context). The references for the Allowlist and the approved exceptions are described in the lichen configuration file. Signed-off-by: Stephen Kitt <[email protected]>
skitt
added a commit
to skitt/submariner-operator
that referenced
this pull request
May 17, 2021
This uses https://github.com/uw-labs/lichen (see submariner-io/submariner#1326 for context). The references for the Allowlist and the approved exceptions are described in the lichen configuration file. Signed-off-by: Stephen Kitt <[email protected]>
tpantelis
pushed a commit
to submariner-io/lighthouse
that referenced
this pull request
May 17, 2021
This uses https://github.com/uw-labs/lichen (see submariner-io/submariner#1326 for context). The references for the Allowlist and the approved exceptions are described in the lichen configuration file. Signed-off-by: Stephen Kitt <[email protected]>
26 tasks
skitt
added a commit
to submariner-io/submariner-operator
that referenced
this pull request
May 19, 2021
This uses https://github.com/uw-labs/lichen (see submariner-io/submariner#1326 for context). The references for the Allowlist and the approved exceptions are described in the lichen configuration file. Signed-off-by: Stephen Kitt <[email protected]>
|
🎉 Great news! Looks like all the dependencies have been resolved: 💡 To add or remove a dependency please update this issue/PR description. Brought to you by Dependent Issues (:robot: ). Happy coding! |
mangelajo
reviewed
May 21, 2021
This uses https://github.com/uw-labs/lichen, which is closer to our requirements for CNCF validation than https://github.com/mitchellh/golicense and performs validation using local information. The references for the Allowlist and the approved exceptions are described in the lichen configuration file. Fixes: submariner-io#801 Signed-off-by: Stephen Kitt <[email protected]>
tpantelis
approved these changes
May 25, 2021
|
🤖 Closed branches: [z_pr1326/skitt/licensecheck] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses https://github.com/uw-labs/lichen, which is closer to our
requirements for CNCF validation than
https://github.com/mitchellh/golicense and performs validation using
local information.
The references for the Allowlist and the approved exceptions are
described in the lichen configuration file.
Depends on #1344
Fixes: #801
Signed-off-by: Stephen Kitt [email protected]