add issn field #1354
Open
add issn field #1354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1354 +/- ##
==========================================
+ Coverage 86.53% 86.53% +<.01%
==========================================
Files 387 387
Lines 7426 7428 +2
==========================================
+ Hits 6426 6428 +2
Misses 1000 1000
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
ISSN field is needed in JournalArticleRef.
What
I just add ISSN field like ISBN in Books.
Also in convertCSLJSON allow import CSLJSON files without DOIs, what are the problems in the further processing? everything seems to work ok in my local copy.