Skip to content

Commit

Permalink
feat: optional args are now specified separately from required args
Browse files Browse the repository at this point in the history
BREAKING CHANGE: optional arguments are no longer allowed to be specified
as a part of FunctionArgument messages.  Instead they are now specified
separately as part of the function invocation.

BREAKING CHANGE: optional arguments are now specified separately from
required arguments in the YAML specification.

Co-authored-by: Benjamin Kietzman <[email protected]>
  • Loading branch information
westonpace and bkietz committed Oct 19, 2022
1 parent f3f6bdc commit 0619413
Show file tree
Hide file tree
Showing 15 changed files with 789 additions and 804 deletions.
2 changes: 1 addition & 1 deletion extensions/functions_aggregate_approx.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
---
aggregate_functions:
- name: "approx_count_distinct"
description: >-
description: >-
Calculates the approximate number of rows that contain distinct values of the expression argument using
HyperLogLog. This function provides an alternative to the COUNT (DISTINCT expression) function, which
returns the exact number of rows that contain distinct values of an expression. APPROX_COUNT_DISTINCT
Expand Down
13 changes: 6 additions & 7 deletions extensions/functions_aggregate_generic.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,22 +5,21 @@ aggregate_functions:
description: Count a set of values
impls:
- args:
- name: overflow
options: [SILENT, SATURATE, ERROR]
required: false
- name: x
value: any
options:
overflow:
values: [SILENT, SATURATE, ERROR]
nullability: DECLARED_OUTPUT
decomposable: MANY
intermediate: i64
return: i64
- name: "count"
description: "Count a set of records (not field referenced)"
impls:
- args:
- name: overflow
options: [SILENT, SATURATE, ERROR]
required: false
- options:
overflow:
values: [SILENT, SATURATE, ERROR]
nullability: DECLARED_OUTPUT
decomposable: MANY
intermediate: i64
Expand Down
Loading

0 comments on commit 0619413

Please sign in to comment.