Apply suggestions from code review

Co-authored-by: Benjamin Kietzman <[email protected]>

site/docs/expressions/scalar_functions.md

@@ -50,7 +50,7 @@ There are three main types of arguments: value arguments, type arguments, and en
 
 In addition to arguments each call may specify zero or more options.  These are similar to a required enumeration but more focused on supporting alternative behaviors. Options can be left unspecified and the consumer is free to choose which implementation to use. An example use case might be `OVERFLOW_BEHAVIOR:[OVERFLOW, SATURATE, ERROR]` If unspecified, an engine is free to use any of the three choices or even some alternative behavior (e.g. setting the value to null on overflow). If specified, the engine would be expected to behave as specified or fail. Note, the value of an optional enumeration cannot be used in type derivation.
 
-### Option Precedence
+### Option Preference
 
 A producer may specify multiple vlaues for an option.  If the producer does so then the consumer must deliver the first behavior in the list of values that the consumer is capable of delivering.  For example, considering overflow as defined above, if a producer specified `[ERROR, SATURATE]` then the consumer must deliver `ERROR` if it is capable of doing so.  If it is not then it may deliver `SATURATE`.  If the consumer cannot deliver either behavior then it is an error and the consumer must reject the plan.
 

site/docs/extensions/generate_function_docs.py

@@ -39,7 +39,7 @@ def write_markdown(file_obj: dict, file_name: str) -> None:
             for count, impl in enumerate(implementations_list):
                 if "args" not in impl:
                     continue
-                args_list = impl["args"] if "args" in impl else []
+                args_list = impl["args"]
                 arg_string = []
                 only_arg_names = []
                 arg_with_option_names = []