Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add logarithmic functions with decimal type args #669

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

scgkiran
Copy link
Contributor

No description provided.

Copy link

ACTION NEEDED

Substrait follows the Conventional Commits
specification
for
release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

@scgkiran scgkiran changed the title feat: Add logarithmic functions with decimal type args feat: add logarithmic functions with decimal type args Jul 24, 2024
Copy link
Contributor

@jacques-n jacques-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to me. I can imagine some systems returning a decimal but suspect most return floats.

@jacques-n jacques-n merged commit d9fb1e3 into substrait-io:main Aug 1, 2024
14 of 15 checks passed
@scgkiran scgkiran deleted the SD-7534 branch August 1, 2024 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants