Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update markup, styling, and js to have better a11y #23

Merged
merged 6 commits into from
Dec 13, 2019
Merged

Conversation

jkeck
Copy link
Contributor

@jkeck jkeck commented Dec 13, 2019

Update facet hierarchy toggling from the <li> to a <button> w/i the <li> so that it can be tab-able, etc.

Fixes #18

In DLME (BL7)

Screen Shot 2019-12-13 at 1 04 28 PM

In SearchWorks (BL6)

Screen Shot 2019-12-13 at 1 08 18 PM

@jkeck jkeck marked this pull request as ready for review December 13, 2019 18:41
@mejackreed mejackreed merged commit 6a8264f into master Dec 13, 2019
@mejackreed mejackreed deleted the keyboard-a11y branch December 13, 2019 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hierarchical facet is not keyboard accessible
2 participants