Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move search header into document split #1173

Merged
merged 1 commit into from
Aug 15, 2024
Merged

move search header into document split #1173

merged 1 commit into from
Aug 15, 2024

Conversation

dnoneill
Copy link
Contributor

@dnoneill dnoneill commented Aug 14, 2024

update default number of result to 20. Closes #1171

Quick notes

  • app/views/catalog/_document_split.html.erb is overriding and override from geoblacklight. The only real change is to add in <%= render blacklight_config.view_config(document_index_view_type).search_header_component.new %> above turbo-frame
  • app/views/catalog/_search_header.html.erb is an override from blacklight. In blacklight it renders the search_header_component which has a partial with <%= render 'did_you_mean' %> <%= render 'sort_and_per_page' %> so I just moved everything into this file and removed sort_and_per_page which is a partial where the only thing in it is render blacklight_config.view_config(document_index_view_type).search_header_component.new

Screenshot 2024-08-14 at 12 55 09 PM

@dnoneill dnoneill merged commit 162eaae into bl8 Aug 15, 2024
3 checks passed
@dnoneill dnoneill deleted the bl8-results-header branch August 15, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants