Smart suggest using search #1180
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edsu
force-pushed
the
bl8-auto-search
branch
2 times, most recently
from
0bb3954
to
5a3339f
Compare
Implement "smart suggest" using the Solr select endpoint rather than suggest in order to get the document IDs for title results. When the user types in a string a search for the string plus * of dct_title_ti and dct_spatial_tmi is performed. The results are stored in an instance of the Suggestions class which has methods to return locations, datasets and maps. Each of the suggestions is an instance of Suggestion which can highlight the query.
|
We decided not to pursue using a Search approach. This was mostly because using the newly configured suggest index in #1154 will guarantee that a certain number of matches from titles and locations are returned, which is not the case when doing a single search against the title and location fields. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement "smart suggest" using the Solr select endpoint rather than suggest in order to get the document IDs for the title results, so they can be directly linked to.
When the user types in a string a search for the string with
*appended ofdct_title_tianddct_spatial_tmiis performed. The results are stored in an instance of the newSuggestionsclass which has methods to return locations, datasets and maps. Each of the suggestions is an instance ofSuggestionwhich can highlight the query.TODO: the Suggester, Suggestions and Suggestion classes need unit tests. I tested with 4k documents and it seemed to perform similarly to the suggest endpoint, but it will be useful to see how it performs with more.
Closes #1047